-
Notifications
You must be signed in to change notification settings - Fork 68
Fix build rules for image.mk #235
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Tamal Saha <[email protected]>
Thanks for your contribution. Could you please share a bit more details why |
Usage in k/k: https://github.com/kubernetes/kubernetes/blob/master/build/pause/Makefile#L83 |
Would it be possible to share some more details here @tamalsaha on why |
There is no So, curl failed. |
Thank you - any further details you can provide about how to reproduce this though? would you be able to fill out details in the "How has this code been tested" section of the PR body? |
Just try from any Mac M1 laptop.
Done! |
do.build.image.%: | ||
@$(MAKE) -C $(IMAGE_DIR)/$* IMAGE_PLATFORMS=$(IMAGE_PLATFORM) IMAGE=$(BUILD_REGISTRY)/$*-$(ARCH) img.build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMAGE_PLATFORMS_LIST := $(subst _,/,$(filter linux_%,$(PLATFORMS))) | ||
IMAGE_PLATFORM := $(subst _,/,$(PLATFORM)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try what exactly? 😇 I'm hoping you can share more precise repro steps here, e.g. the specific commands to run to repro this and where to run them from. Thank you! 🙏 |
Description of your changes
We are not using xpkg instead using the img.mk build rules to package our images. This pr makes the minimal changes to fix the build rules and build multi-arch image using
docker manifest
command.Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested
I was able to use my fork to build and publish images
https://github.com/kubeform/provider-gcp/actions/runs/5395921949/jobs/9798952056